Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project and execution opening commands #16

Merged
merged 6 commits into from
Apr 13, 2017
Merged

Project and execution opening commands #16

merged 6 commits into from
Apr 13, 2017

Conversation

akx
Copy link
Member

@akx akx commented Apr 13, 2017

No description provided.

@akx akx requested review from orasimus and ruksi April 13, 2017 12:17
@codecov
Copy link

codecov bot commented Apr 13, 2017 •
edited
Loading

Codecov Report

Merging #16 into master will decrease coverage by 0.13%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   92.38%   92.24%   -0.14%     
==========================================
  Files          64       68       +4     
  Lines        1589     1651      +62     
  Branches      197      201       +4     
==========================================
+ Hits         1468     1523      +55     
- Misses         66       69       +3     
- Partials       55       59       +4
Impacted Files Coverage Δ
tests/fixture_data.py 100% <ø> (ø) ⬆️
valohai_cli/api.py 86.36% <100%> (-1.14%) ⬇️
tests/commands/execution/test_open.py 100% <100%> (ø)
tests/utils.py 100% <100%> (ø) ⬆️
valohai_cli/commands/execution/open.py 100% <100%> (ø)
tests/commands/project/test_open.py 100% <100%> (ø)
valohai_cli/commands/project/open.py 100% <100%> (ø)
valohai_cli/commands/project/status.py 67.64% <42.85%> (-7.36%) ⬇️
valohai_cli/utils.py 88.7% <77.77%> (-1.86%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d808991...501ef0e. Read the comment docs.

ruksi
ruksi approved these changes Apr 13, 2017
View reviewed changes
Copy link
Member

@ruksi ruksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruksi ruksi merged commit d715478 into master Apr 13, 2017
@ruksi ruksi deleted the open-proj branch April 13, 2017 12:35
@akx akx mentioned this pull request Mar 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruksi ruksi ruksi approved these changes

@orasimus orasimus Awaiting requested review from orasimus

Assignees

@orasimus orasimus

@ruksi ruksi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akx @ruksi @orasimus